Pull Request Feedback A DVCS pull request approach to personal - PowerPoint PPT Presentation

Pull Request Feedback A DVCS pull request approach to personal feedback ludwig@schubert.io

duh.

3 1 2 4 5

How does the issue manifest? What is your interpretation? How would you suggest to fix it? Explain the reasoning of your fix. Show you made it easy to apply.

tiny.cc/pr-feedback Pull Request Feedback Personal feedback based on the open source pull request culture How does the issue manifest? Think about what exactly doesn’t work the way you’d like it to. 
 Focus on manifestations, not yet on explanations. 
 + What is your interpretation? Give a traceable explanation of your believes of why the issue arose. If you aren’t accusatory, this can give your counterpart a chance to correct your reasoning. 
 Pull Request Feedback Pull Request Feedback How would you suggest to fix it? A DVCS pull request approach to personal feedback State these suggestions as a form of personal belief—because they are. It is helpful to show your approach in detail, without defending it or arguing for it. 
 A DVCS pull request approach to personal feedback Explain the reasoning of your fix. ludwig@schubert.io Separating this from step 3 allows you to argue in a less emotional way, describing your deductions in an almost mechanical matter. This often helps you spot where your ludwig@schubert.io suggestion relies on personal beliefs as well. Show you made it easy to apply. This step firstly consists of making your suggestion easy to implement. Set up a new schedule for that meeting. Just like you write a pull request that can be merged 
 without conflicts and test coverage on par with the standard for the project you contribute to. The idea is to make it easier to accept your suggestion than to reject it. You’re overcoming status-quo bias here, so be prepared to invest a lot of effort. Available at http://schubert.io/pr-feedback-poster.pdf (CC BY-NC-SA) Thank you for being awesome to one another. Direct feedback to @ludwigschubert or ludwig@schubert.io. (Yes, I will send you the sources to this poster and the presentation so you can make it easy for me to accept your sugg

Thank You. For your feedback: 
 @ludwigschubert 
 ludwig@schubert.io

How does the issue manifest? FREE 
 META 
 LEVEL! What is your interpretation? How would you suggest to fix it? Explain the reasoning of your fix. Show you made it easy to apply.