[Code] Review for Test Automation Nicolae Oprean QA Technical Expert
Who am I? Nicolae Oprean ❯ QA Technical Expert at Ullink ❯ PhD in Computer Science ❯ Programmer (1y), Client Service (5y) and QA (6y) [Code] Review For Test Automation
QA Paradigm Initial Problems 1 year later => a portfolio of 1000+ (manual) test cases START When I joined, we had 200 manual test cases stored in Excel files [Code] Review For Test Automation
QA Paradigm Automation Focus 5 QAs started automating Extracted smoke tests outside of the full suite [Code] Review For Test Automation
QA Paradigm What else can we do? ❯ Best practices stored in Confluence ❯ Do formal code reviews ❯ Integrate with Gerrit and GIT ❯ Request help from developers [Code] Review For Test Automation
Current QA Review Process Both QAs and developers review test automation code Cross-functional teams Test automation code is DAMP & DRY 3D interaction between QA teams [Code] Review For Test Automation
Benefits of Code Review Improves Code Functional Knowledge Technical Knowledge Reduced Cost of Fixing Quality Transfer Transfer Bugs (Higher Bus Factor) [Code] Review For Test Automation
Rules for Code Review -2 This shall not be merged -1 I would prefer this is not merged as it is 0 I reviewed the change (partially or fully) but don’t have an opinion yet +1 Looks good to me, but someone else must approve +2 Reviews look good to me, approved [Code] Review For Test Automation
Code Review Schema [Code] Review For Test Automation
Gerrit Dashboard [Code] Review For Test Automation
Foreman / Forewoman Uncle Bob’s thoughts: ❯ Concept of the responsibilities on a construction site: the foreman’s role ❯ How this maps to software development, in particular to the code review process Useful reading from Uncle Bob: ❯ Where is Foreman? ❯ Oh Foreman, Where art Thou? ❯ A Spectrum of Trust [Code] Review For Test Automation
Foreman Role Within Our Company Self-obviating Introduced a system pre-merge code Encouraged and review tool supported people to do as called Gerrit much code review as Started off with a small possible across projects number of and technologies When the quality and foremen quantity threshold was reached, people got appointed foreman [Code] Review For Test Automation
Total Number of Foreman [Code] Review For Test Automation
Gerrit Review Downsides Initial problems ❯ Many reviews vs. too few people to approve ❯ Length of the process... ❯ Persisting frustration [Code] Review For Test Automation
Gerrit Review Tool Improvements ❯ Easy to be reviewed - Gerrit dashboard displays size of commit ❯ Visibility - Integration with Slack ❯ Responsibility - Punish self-reviewers through cats [Code] Review For Test Automation
Review Tips Avoid the “Why” Criticize the code Ask questions Remember that Remember to questions… praise… not the writer rather than make there is often more statements… than one way to approach a solution… Don’t rush Suggest an Format your Help people to Team commitment improvement through code comments to be improve instead of saying review clean and readable code is bad [Code] Review For Test Automation
Language Agnostic Rules 1 2 3 4 A patch must be small A class or method Methods must be Code must be clean and relate to a single should have a single clear and readable unit of work responsibility [Code] Review For Test Automation
Lessons Learned Foster technical discussions Ask, don’t yell • What do you think about … ? • Did you consider … ? • Can you clarify … ? Avoid negativity … be positive “ Why didn’t you just … ?” Follow a review checklist • Best Practices • Functionality • Complexity Sustain a strong code review culture • Better Code • Better Developers • Team Ownership • Healthy Debate [Code] Review For Test Automation
Summary Use an automated Do Code Review DAMP & DRY Bus Factor code review tool with Developers Share knowledge Maintain lessons Shorten feedback with others learned loops [Code] Review For Test Automation
Questions? Nicolae Oprean QA Technical Expert Twitter: @noprean Email: nicolae.oprean@ullink.com Linkedin: nicolae-oprean
Recommend
More recommend
