Contributing to Zeek Tim Wojtulewicz, Corelight PROPRIETARY AND - PowerPoint PPT Presentation

Contributing to Zeek Tim Wojtulewicz, Corelight PROPRIETARY AND CONFIDENTIAL

That’s Woah-2-la-wits If you were confused by all of the consonants jammed together PROPRIETARY AND CONFIDENTIAL

Talking today about how to open pull requests for Zeek issues PROPRIETARY AND CONFIDENTIAL

Picking an issue (optional) PROPRIETARY AND CONFIDENTIAL

Fork the repo PROPRIETARY AND CONFIDENTIAL

Clone the repo git clone git@github.com:zeek/zeek.git PROPRIETARY AND CONFIDENTIAL

Configure and build cd zeek ./configure --prefix=/some/path cd build make PROPRIETARY AND CONFIDENTIAL

This is the part where you open emacs and fix the issue PROPRIETARY AND CONFIDENTIAL

You are using emacs, right? PROPRIETARY AND CONFIDENTIAL

Run the tests cd testing/btest btest -j 6 If it succeeds: 981 tests successful, 67 skipped Don’t worry about those skipped tests, that’s intentional. PROPRIETARY AND CONFIDENTIAL

Commit your change to your fork git checkout -b <branchname> git commit -a -m “GH-###: Some descriptive commit message” git push -u origin -b <branchname> The GH-### part will cause Github to automatically close the issue when the PR is merged. PROPRIETARY AND CONFIDENTIAL

Create the pull request, part 1 PROPRIETARY AND CONFIDENTIAL

Create the pull request, part 2 PROPRIETARY AND CONFIDENTIAL

Create the pull request, part 3 PROPRIETARY AND CONFIDENTIAL

Wait for someone to review PROPRIETARY AND CONFIDENTIAL

Review feedback -> fixes -> new commits -> more reviews PROPRIETARY AND CONFIDENTIAL

Maintainer will merge to master PROPRIETARY AND CONFIDENTIAL

Dog tax? PROPRIETARY AND CONFIDENTIAL